Enhance random HTML file selection and error handling#155
Draft
prettyleaf wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the
randomhtml()function insrc/modules/selfsteal_templates.sh, enhancing the logic for selecting and preparing random HTML templates, as well as making the HTML modification process more robust. The main changes include a more flexible template selection mechanism, improved error handling, and a more reliable approach to modifying and verifying HTML files.Template selection and preparation improvements:
.htmlfiles in the current directory, rather than just files named1-8.html. This makes the function more flexible and future-proof.HTML modification and validation enhancements:
sedcommand that injects a random class into the<body>tag so it now correctly handles cases where the tag may or may not already have aclassattribute./var/www/htmldirectory always exists before copying or extracting templates, and reorganized the directory creation check for clarity and reliability.grep -Rqlcommand, ensuring the modification is validated correctly.